Patrik Ragnarsson

> I can see possibly having to change existing PRs, or links to commits breaking but could you explain more how this could disturb other folks? I mean disturbing as...

@GildedHonour You can use Sinatra 2.1.0 with Ruby 3.0 but there's some use-cases that doesn't work. The ones I know about are https://github.com/sinatra/sinatra/pull/1684 and https://github.com/sinatra/sinatra/pull/1701.

I think the `master` branch (possibly renamed to `main`) should be our "unstable" branch. It is too confusing with both `master` and `unstable`, we get duplicated pull requests like: https://github.com/sinatra/sinatra/pull/1740...

@epergo See https://github.com/github/renaming#renaming-existing-branches

Does those tests fail on master too?

@voxik still an issue?

@jkowens I think we can close this issue now. @voxik can create a new issue if it is still an issue with the latest release.

I'll note that Rack 3 was just released. https://rubygems.org/gems/rack/versions/3.0.0, https://github.com/rack/rack/commit/52901caf09ebcda879512a8605059963a49df55d

I think the issue is your constructor: https://github.com/Deer-Spangle/FAExport-StressTest/blob/dc9850794a88e2e6a7553013f1176108035792ce/sinatra_app/lib/faexport.rb#L78-L108 Everything defined there is shared between all requests. Your Sinatra application is just another Rack middleware. See https://github.com/spinels/rack-ssl-enforcer/pull/2 for a similar example.

The instance variables you define in the constructor `initialize` are shared between the requests. That is not the case if you define them in before/after/routes. I've never seen `def initialize`...