Patrik Ragnarsson

Results 301 comments of Patrik Ragnarsson

``` $ head -n1 $(which puma) #!/usr/bin/env ruby $ which ruby /Users/dentarg/.rubies/ruby-2.7.1/bin/ruby ``` Ah, I see... so it comes from the code at https://github.com/postmodern/chruby/blob/v0.3.9/share/chruby/chruby.sh#L45-L49. I see the `extensions are not...

``` $ tree "$GEM_HOME/extensions" /Users/dentarg/.gem/ruby/2.7.1/extensions └── x86_64-darwin-18 └── 2.7.0-static ├── RedCloth-4.3.2 │   ├── gem.build_complete │   ├── gem_make.out │   ├── mkmf.log │   └── redcloth_scan.bundle ├── bluecloth-2.2.0 │   ├── bluecloth_ext.bundle │   ├──...

I'm setting a default Ruby [like the README suggests](https://github.com/postmodern/chruby#default-ruby) ``` $ cat ~/.ruby-version 2.7.1 ``` If I remove this file, the `Ignoring ... because its extensions are not built` messages...

@eregon ``` $ ruby -e 'p RbConfig::CONFIG["ENABLE_SHARED"]' "no" $ ruby -v ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x86_64-darwin18] $ which ruby /Users/dentarg/.rubies/ruby-2.7.1/bin/ruby ```

> Reopening [this pr](https://github.com/sporkmonger/addressable/pull/340) with just the minimum changes to fix the issue blocking our use of the current version. I'm curious, what are the issue you are facing with...

Got it, thanks. I think we need to add tests for this.

From https://github.com/sporkmonger/addressable/issues/401#issuecomment-777883236 >I think it's worth calling out that Addressable's `heuristic_parse` does aim to hew quite closely to whatever browsers are doing in the address bar. If I enter `//test.com`...

@brasic I interpret the answer from @sporkmonger that a PR resolving this would be accepted! I agree with it being a major version bump when released.

> silent acceptance of `//` prefixes _as if_ they were simply `/`, are exceedingly common, from web servers, to Linux filesystem paths, to `Rails` itself Do you have more concrete...

Re: the file URI scheme, I think Addressable is doing the correct things, see [https://en.wikipedia.org/wiki/File_URI_scheme#How_many_slashes?](https://en.wikipedia.org/wiki/File_URI_scheme#How_many_slashes?) (until I looked this up, I didn't know that `file:` supported hostnames, so TIL 😅)...