Patrik Ragnarsson

Results 301 comments of Patrik Ragnarsson

We probably want `statsd` as an optional dependency

Sorry, I was thinking too much like a Ruby developer when I said we could make `statsd` an optional dependency :) Here we compile a binary so it makes sense...

Nice, if you rebase with master CI should run

Yes, the linting issues hasn't been solved in master yet. I've excluded that step now, if the event that triggers the CI workflow comes from a fork, so if you...

Great work @elliotfehr @carlhoerberg WDYT?

Nice work @elliotfehr, just tried it out locally. I'm thinking a nice touch would be to print on upstart that StatsD reporting will be used (if it has been configured),...

@elliotfehr mind resolving the conflicts? GitHub didn't let me commit to the branch

Sorry about that, and thanks for fixing the conflicts. LGTM but I'll let @carlhoerberg merge it.

>New PRs run actions twice, once for PR and once for push trigger. I haven't double checked this but I think this is only the case when the PR doesn't...

I agree, it should continue to be easy to work in a fork