Patrik Ragnarsson

Results 771 comments of Patrik Ragnarsson

This sounds like a feature request more than a bug, going of the [current documentation](https://github.com/puma/puma/blob/9bd838bfc9a987d902760c75c6141eb2455df749/docs/restart.md#client-experience-1) that states `Idle persistent connections are gracefully disconnected`

No need to create a new issue. I was just setting exceptions / contributing to the discussion. Maybe the title should be tweaked, but we can await feedback from others.

sd_notify is an optional dependency. It will not be forced upon every user of Puma.

Let's discuss your comment at https://github.com/puma/puma/pull/3011#issuecomment-1883329515 here instead of the closed PR > As a Fedora maintainer, I am disappointed with this PR and with bundling in general. What was...

> sd_notify is an optional dependency. It will not be forced upon every user of Puma I guess that wasn't the most clever statement, as I realise it can be...

> Not sure what are the "certain (restart/reload) features", which would speak for bundling I was thinking of phased restart: https://github.com/puma/puma/discussions/3034

Even if Puma didn't have the phased restart feature, I suspect we wouldn't want to add an explicit dependency on the sd_notify gem, as it is (my guess) used by...

Looks like it possible to specify multiple licences in the gemspec: https://guides.rubygems.org/specification-reference/#licenses=

Are the test failures related to (these) tests now using preloading (and that causes some problem)? While https://github.com/puma/puma/issues/3044 is classed as a bug, it is quite the change in behaviour......