Patrik Ragnarsson

icon indicating a website link https://dentarg.net icon indicating an email [email protected]

icon company @cloudamqp icon location Sweden icon location Software developer with interest in security, web and mobile. ⚡️

Results 771 comments of Patrik Ragnarsson

Test Framework Update (Draft, review only)

What's the motivation behind `minissl.rb - set @eng_ctx = nil to nil on close` (https://github.com/puma/puma/pull/3267/commits/5eec16a2257d706a6fbd9baa575a8938c9dd6d84)? Maybe that should go in as a separate PR as it the only change to...

Test Framework Update (Draft, review only)

This is awesome work. No question about it. It will be much easier to maintain and contribute to Puma if we get the CI stable. We can probably go ahead...

Add a hook for "before shutdown"

Hmm, isn't it better to instruct your load balancers to take out the server of the rotation when you want to restart it? (Not sure what you're using but HAProxy...

Add a hook for "before shutdown"

Sounds cool… feel free to elaborate :)

Feature/support custom logger with request logs

> I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature. can't see you have ;)

Feature/support custom logger with request logs

> We now have 2 changes on master for v7 Which are those? I just created an 7.0.0 milestone, would be good to add their issues/PRs to it.

Set env['rack.hijack'] to client.method(:full_hijack) instead of client instance

I see what this does (and if you only call `call` on this object this change shouldn't be breaking, right?) but can we spell out the benefits/motivation as to why...

`preload_app` doesn't default to `true` if more than 1 worker

Thanks for this great summary. I've actually come to the same conclusion before, at https://github.com/puma/puma/pull/2481#discussion_r519086284 and in https://github.com/puma/puma/issues/2483. I think what was discussed in #2483 for Puma 6 must have...

`preload_app` doesn't default to `true` if more than 1 worker

So, Puma will preload your app if you start it using `WEB_CONCURRENCY=N puma ...` (N >= 2)

lib/client.rb - use Tempfile.create instead of Tempfile.new for request bodies

Not related, just things I've read on the topic of `Tempfile` that I'll link from here as I may look for them again in the future: * https://github.com/rack/rack/issues/1679#issuecomment-826779456 * https://github.com/rack/rack-test/pull/339