Patrik Ragnarsson comments

Results 771 comments of


                                            Patrik Ragnarsson

Catchall error block fails to catch direct decendants of Exception

@epergo @jkowens what are you thoughts here? Should we consider any implementation change?

Failing tests with ruby-head

Maybe https://github.com/ruby/ruby/pull/9460

Failing tests with ruby-head

So https://github.com/sinatra/sinatra/commit/d6294df43bdca531d04a5ab5bc3fcc58f2ce99bc didn't help, that's interesting

We have more fails, sinatra tests too: https://github.com/sinatra/sinatra/actions/runs/7476448903/job/20346834173#step:5:25 Maybe this one https://github.com/sinatra/sinatra/blob/fa5a1399b6b63bcca2df81db284ff64a89a2b599/test/routing_test.rb#L763-L766

Failing tests with ruby-head

From @byroot on Slack > Clearly a bug IMO. That line doesn’t mutate that interpolated string. So it should be reported to https://bugs.ruby-lang.org/, but it would be good to have...

Failing tests with ruby-head

@byroot Oops, of course 🤦 didn't think that through. Thanks.

Failing tests with ruby-head

ruby-head no longer has any failing tests (example: https://github.com/sinatra/sinatra/actions/runs/8448241782)

Update streaming to make use of Rack "callable body"

I think this is relevant to look at/read: https://github.com/rails/rails/pull/52094

Remove use of `TemplateCache`

We have also this recent comment from https://github.com/jeremyevans/tilt/issues/6#issuecomment-1584993727 about it > The easiest upgrade path for other projects using Tilt::Cache, would be to copy the code from Tilt and use...

Remove use of `TemplateCache`

@jeremyevans do you have any suggestion/idea what to replace it with? Something like [`RodaCache`](https://github.com/jeremyevans/roda/blob/58c6e89bacc69abe57074736580ba31a89db0ede/lib/roda/cache.rb) perhaps?