Patrik Ragnarsson
Patrik Ragnarsson
I like your suggestions, it looks like a good plan to me
Just want to give my opinion on this topic. I do think Terraform should address this issue. I think it will increase the usefulness and ease of use of Terraform....
@vbisbest Please to debug your issue further and at least include logs when reporting an issue. Installing thin on Apple Silicon works for me: ``` arm64 $ uname -srm Darwin...
With `set :show_exceptions, false` (or `RACK_ENV=production`), I can see the error block being called, even with `raise StandardError` using Sinatra 2.0.5.
> If `:raise_errors` is `true`, then the catch-all works as described. Isn't #1914 showing the opposite? https://github.com/sinatra/sinatra/blob/70151c97ebf0ee36c7b3dbb7303c4da968bc0f0f/test/mapped_error_test.rb#L121-L130
Just noting a thing here as I looked it up: > Because the conditional on this line checks for strictly less than instead of less than or equal to, error...
Is the bug that any error handlers are called when `raise_errors` are `true`? 🤔
Thanks for clarifying and providing more background info. I guess it depends on how you view your use of the catch-all (`error do ... end`), is it only there to...
I guess you would set `raise_errors` to false for that test?
Thanks for that thorough comment @carlwiedemann. I also like consistency. I think 4. is what we can do short term. For a new major version we could consider the other...