deathcap
deathcap
Reading the code now, only the opaque bit overlaps with the possible voxel types, the AO flags are stored beyond the 16 bits. Passing the opaque flags in a separate...
Maybe could use the voxel plugins system https://github.com/voxel/voxel-plugins directly? I haven't tried using it for other purposes outside of voxel.js (except in the test suite), but it doesn't have any...
> It's a bit hacky and it assumes plugins do listen on loading and not after but what would be possible is comparing the list of listeners before and after...
https://github.com/wtfaremyinitials/stream-pipeline has been inactive 8 months and is not published to NPM, but there is another module on NPM of the same name: https://www.npmjs.com/package/stream-pipeline - "When you want to connect...
:+1: for native ws in nmp. Currently wsmc is [broken](https://github.com/deathcap/wsmc/issues/19), I think the relevant bits could be easier to maintain in sync with this repository if they were a part...
Or maybe, refactor node-minecraft-protocol to operate on node.js [streams](https://nodejs.org/api/stream.html#stream_stream) instead of TCP sockets? References: TCP: https://github.com/PrismarineJS/node-minecraft-protocol/blob/master/src/createClient.js Stream: https://github.com/deathcap/wsmc/blob/master/minecraft-protocol-stream.js Since streams are an abstract interface, using them with websockets is as...
But the `createClient()` API [accepts](https://github.com/PrismarineJS/node-minecraft-protocol/blob/master/src/createClient.js#L32) `host` and `port` options, which it passes to `net.connect()` to get a stream for `setSocket()` — I'd like to [pass](https://github.com/deathcap/wsmc/blob/2a4416adcd39a2403a3a73cf1adc947ec1aaa5e8/minecraft-protocol-stream.js#L33) createClient a stream directly.
It's a good idea, the changes in modularizing NMP I think would be useful for websocket support: - [ ] Protocol stream access: allow connecting NMP directly to a `Stream`,...
Prototyping sort of what I had in mind in: https://github.com/PrismarineJS/node-minecraft-protocol/pull/320 Client stream - factoring out the common code (keep alive, login state change, compression request), which both WS and TCP...
For the multiple writes wrt Nagle, I think that's worth discussing further, in https://github.com/PrismarineJS/node-minecraft-protocol/pull/316 Not having a direct dependency on websocket-stream in NMP, looking into this some more, I agree....