Daniel Cousens
Daniel Cousens
Using `atob`/`btoa` is strongly preferred, if at least for the first attempt for easier code review. We can optimize afterwards.
What is the browser performance like? We could probably still rely on `atob` and `btoa` and then log the nodejs issue upstream?
I have added a comment in https://github.com/nodejs/node/pull/38433#issuecomment-1926594891, and I suspect that's where we can leave it. We are targeting browsers, and the fact that `atob` and `btoa` is slow in...
@chjj I think we can probably say that `btoa` and `atob` _should_ be faster and better maintained in the long-term
Another reason - https://github.com/keystonejs/create-keystone-app/pull/383
See https://github.com/keystonejs/keystone/pull/9102
@RodrigoNovais the code falls back to `npm` if `yarn` isn't installed. https://github.com/keystonejs/create-keystone-app/blob/780a3c6f787dba1cc5b36ee2893881fd948ffe0f/create-keystone-app/src/index.ts#L50-L67 You could probably write up something that uses the `process.env.npm_config_user_agent` to determine what package manager is in use.
@theoparis we agree this is painful, we'll be removing that and changing this to a two step process instead. Stay tuned!
Thanks for the detailed description @zicklag, this should be enough for us to recreate the issue if it's on our end. It's likely that `prisma` was attempting to download the...
Superseded by https://github.com/keystonejs/keystone/pull/9102