Daniel Cousens

Results 565 comments of Daniel Cousens

I have updated this pull request and rebased each of the changes. I effectively did the changes again from HEAD, to ensure I understood everything that was changed, but the...

@yorkeJohn can you provide any additional details about your environment?

I'm seeing a trend of Windows paths in the reports 👀

I don't know if `virtual` is the right abstraction for this, and `JSON` is too opinionated. I don't think I can accept this pull request, but I will tag you...

Are you using `io-ts` or `fp-ts` in your project?

I think potentially we need to add `fp-ts` as a peer dependency to the `@keystone-6/fields-document` package - pull requests accepted!

Fixed in https://github.com/keystonejs/keystone/pull/9263

> I was looking at [create-payload-app](https://github.com/payloadcms/payload/tree/main/packages/create-payload-app) maybe we can borrow that code for KS also, which will allow multiple KS templates I don't mind the idea of different templates, but...

@iamandrewluca before I review this in depth, can you please highlight any changes you needed to make when porting this from https://github.com/keystonejs/create-keystone-app (as comments on the diff). This will help...

Checking the `diff` against https://github.com/keystonejs/create-keystone-app, and removing a few deprecated files from `create-keystone-app`, and ignoring the `package.json`: ```diff diff -r ../../../create-keystone-app/cli.js ./cli.js 2,3c2 < 'use strict'; < require('.'); --- >...