Daniel Cousens

Results 552 comments of Daniel Cousens

@slotThe `historyCompletionP` needs `conf` either way, but yes branching as I mentioned is an alternative approach > historySize = 0 could branch the behavior, and prevent any related IO (reading...

@slotThe I have changed the pull request to pattern match `historySize = 0` for `readHistory` and `writeHistory`

@slotThe the only downside to a non-breaking change is that `historyCompletionP`, if used, will not respect the new behaviour (for better or worse), I think this is the right path...

@slotThe to clarify, you think I should introduce a breaking change [that you have suggested] in this pull request? Assuming yes, I'll try and do that this weekend

OK, I'll have a shot at that, I'd prefer that personally

Rebased and added a breaking commit, which ensures that `historyCompletion*` now accepts an `XPConfig`

https://github.com/JedWatson/react-tappable/blob/master/src/TappableMixin.js#L68 - however I'll need a test case to understand, as at this stage, I don't understand why that advice is there unless you're somehow handling `onTouchStart` yourself (outside of...

@ljharb shall we close?

@ianwith can't you do this yourself for your own project? :/