David Buchmann

thanks for looking into this! how about disabling the coveralls step completely when php version is 8, until coveralls fixes their signature to be compatible with symfony? or even mark...

thanks for offering to help! to do the cleanup changes, rector sounds like the right tool. about adding the configuration: could we enable some rules in php-cs-fixer to detect incomplete...

hi, thanks for the detailed explanation of why you want this :+1: i think raising filter start and finished events sounds like a good idea. it could also be used...

i think the bundle documentation should mention and link it in some place (maybe list the features of the library in the bundle introduction?). and do we have DI tags...

@xDaizu i am not sure if anybody currently maintaining this bundle is the person who wrote that part of the code. we all dig into things and figure out stuff....

thanks for bringing this up. in other OS bundles i maintain, we have have a github action to build the documentation, including an .rst spellchecker (e.g. https://github.com/FriendsOfSymfony/FOSHttpCache/blob/master/.github/workflows/spellcheck.yml). this both is...

the github actions in the example i linked are using the python sphinx library (makes sense for that repo because that is what readthedocs is using). i think for the...

@stephanvierkant do you plan to follow up on the feedback? i would love to get these improvements in once we figured out the remaining questions.

semantically the ul / li seems the correct thing to do. but if there is a good use case for more flexibility, we should make the template more flexible, yes....

@stof how would you feel about a refactoring as gremo proposes? it seems safe enough to me, and would be BC as its just adding new blocks.