LiipImagineBundle icon indicating copy to clipboard operation
LiipImagineBundle copied to clipboard

Added return types

Open stephanvierkant opened this issue 4 years ago • 4 comments

Q A
Branch? 3.x
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Fixed tickets #1415
License MIT
Doc

Added or changed some return types. Most of the methods already had a return type. I couldn't find any methods where a parameter type declaration could be added.

stephanvierkant avatar Dec 07 '21 18:12 stephanvierkant

@stephanvierkant do you plan to follow up on the feedback? i would love to get these improvements in once we figured out the remaining questions.

dbu avatar Jan 04 '22 07:01 dbu

Any news ?

cbeyer avatar Jun 12 '23 13:06 cbeyer

i would love to get this moving again, but have little time. @cbeyer if you want to pick up the branch from stephan and do a new pull request with the conflicts resolved and possibly more strict typing cleanup, please do and i will be happy to review the changes.

dbu avatar Sep 23 '23 15:09 dbu

@tacman this would be a crucial bit to modernize the code for 3.x

dbu avatar Jan 02 '24 19:01 dbu