David Buchmann comments

Results 944 comments of


                                            David Buchmann

Allow overwriting services in test

symfony 3.2 deprecates setting any services into the container after the container has been built. this also affects what we can do here. there is an issue on the symfony...

Allow overwriting services in test

thanks for these inputs. maybe we should just link these two things (TestDoubleBundle and your examples) in our documentation but consider it out of scope for the LiipFunctionalTestBundle?

Allow overwriting services in test

maybe have a section in the readme or the doc intro that tells what is out of scope for this bundle, with pointers to other resources?

use expression language for path_patterns

sorry, no plans to do that anytime soon. just saw it in the README and thought this looks like it was done before expression language existed.

Default path that assetic can handle

is this fixed by https://github.com/liip/LiipThemeBundle#assetic-integration ? the above link no longer works.

Add custom twig loader to workaround cache issue

ping @xanido

require all necessary psr implementations

i tried running the tests locally, but they fail because the tests assume the json is decoded to array, but RestClient::handleResponse does json_decode with `false`, so creating stdClass objects. i...

How should we handle token expiration? Not sure if go-cfclient handles this for us.

our application is now set up to build a new client every 24 hours to get a new refresh token before the old one expires. ``` func newApiClient() { ......

forward the context from the JsonEncoder to JsonEncode and JsonDecode

@dunglas does this approach make sense? and would you have an idea what i got wrong with the service configuration?

forward the context from the JsonEncoder to JsonEncode and JsonDecode

thanks. i rebased on 6.2 and updated the commit. i think the build errors are not related to my change but broken in the 6.2 branch.