David Buchmann

Results 944 comments of David Buchmann

ok, thanks. at least not a regression then :see_no_evil: i wonder if it would be considered a BC break if we fix that. this is not really the subject of...

if somebody has to be time to investigate and propose a fix, i am happy to review it, but i don't have time to dig into it.

i am cleaning up old issues. if this is still relevant and keeps happening with the latest version of the bundle, please reopen the issue.

i reopened the issue. can you propose a solution @jkabat how this should be handled?

i am looking at older issues. is this one still relevant to you? if it is, where would you expect the event to happen? on CacheManager::store? for my understanding, could...

it looks like somebody did a PR for this once, but then dropped it: https://github.com/liip/LiipImagineBundle/pull/1127 do you want to redo this code? i am trying to be active on this...

> I am curious as to why the PR was dropped from the time between opening and closing, i assume that the author deleted the fork at some point, after...

hm, i would have expected this to work. but looking at https://github.com/liip/LiipImagineBundle/blob/1a04fac4dd9d318a3a42fedc81896d874b8a7e64/DependencyInjection/Configuration.php#L119 it seems to me that the default of the filter-set is always set and will win over the...

i think having such css classes in configuration would indeed be a good idea. css frameworks tend to need a specific class for that, not easy to remap on css...

the problem with handling that over such a parameter is that its very implicit. it does not show when you dump the configuration options, and if you mistype it, you...