LiipImagineBundle icon indicating copy to clipboard operation
LiipImagineBundle copied to clipboard

[WIP] Change phpunit workflow to allow disabling specific test environments when incompatibilities are encountered.

Open robfrawley opened this issue 4 years ago • 3 comments

Q A
Branch? 3.x
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? yes/no
Fixed tickets https://github.com/liip/LiipImagineBundle/pull/1436#issuecomment-983360655
License MIT
Doc n/a

I am testing some different changes to resolve the above-titled issue; no single solution to the problem has been determined appropriate for this project yet. As such, do not merge! __

robfrawley avatar Dec 01 '21 18:12 robfrawley

Looks like we need to wait on php-coveralls/php-coveralls#328 for a resolution to our failing workflows when running with any Symfony 6.x release.

@dbu: For the time being, do you want me to update the workflow matrix to disable coveralls reporting on incompatible environments? If so, we could do that in such a way as to quickly be able to enable/disable certain environments easily, something that will likely be useful again in the future when a different incompatibility pops up...

robfrawley avatar Dec 01 '21 18:12 robfrawley

thanks for looking into this!

how about disabling the coveralls step completely when php version is 8, until coveralls fixes their signature to be compatible with symfony? or even mark just 1 build in the matrix to actually do the coveralls things. i don't think we need coverage for each case.

dbu avatar Dec 02 '21 07:12 dbu