David Pedersen

Results 379 comments of David Pedersen

I have started looking into this but since I'm new to this project I have a few questions: 1. Currently [`juniper::execute`] starts off by validating the variables and query against...

No. You need to write out the full types. I'd recommend writing things such that you don't have to do that.

Nope don't think so. You're welcome to open a discussion/question in you have a specific problem.

tower-http doesn't know anything about axum so I don't think its appropriate for its docs to treat axum with special attention. axum has docs [here](https://docs.rs/axum/latest/axum/routing/struct.Router.html#nesting-services) and [here](https://github.com/tokio-rs/axum/blob/main/examples/static-file-server/src/main.rs) that shows how...

> I think a trace of the path being asked for (after being cut up etc.) and then a trace of the file system path being tried would be very...

Adding a method for specifying the preferred compression (if the client doesn't have a preference) sounds good to me!

I'd call it `RequestDecompression` and put it in the `decompression` module if possible

I think we should also consider making separate middleware for (de)compressing requests and responses rather than making one middleware do both. It's easy to apply both if that's what users...

Yes sorry. It was mostly a note to myself. Haven't actually read your code yet 😅