David Pedersen

Results 405 comments of David Pedersen

Ah yes that example is indeed out of date. axum always uses `axum::body::Body` for requests and responses since 0.7. > What is any_service() good for now? It can still be...

Exactly. You might also wanna run the MethodRouter, without using Router at all.

> Is any help needed to bring this change over the finish line? Nope. Its a breaking change and don't wanna start merging breaking PRs just yet. It is done...

It’s still needed. Router is not Sync because it contains services that aren’t Sync. That limits our options to use things like Arc internally. So it’s not related to work...

> Considering that once things are setup, we only use the router for reading (routing), what's wrong with using Arc internally? `Service::call` takes `&mut self` so it’s not just for...

> Been mulling over this for a few days, and had an idea. How about we wrap everything in an Arc, and when a particular service needs to be called,...

The limit you're running into is most likely https://docs.rs/axum/latest/axum/extract/struct.DefaultBodyLimit.html. It has a method to disable the default limit.

Yeah I'm open to that. However its a bit tricky since extractors can't really be configured currently, as they're types in function arguments. So if you have `async fn handler(form:...

Sounds like a good fit for axum-extra. Then we can move it to axum when it’s matured.