David Pedersen

Thanks! I'm not sure when I'll get time to review this. Going on vacation in a few days. So might not get time before I'm back in a few weeks.

I am 😊 I'll try and have a look soon.

I still wanna look through. Please remain patient.

First of all thank you for working on this! I've skimmed the code and it looks solid overall. With that said I have some concerns: My biggest concern is that...

I think a builder method on `CompressionLayer` and `Compression` a la ```rust CompressionLayer::new().level(the_level) ``` is fine. I think we can copy https://docs.rs/async-compression/latest/async_compression/enum.Level.html into tower-http and internally map between them, to...

Thanks for the detailed breakdown!

@mdickopp Thanks for your work on https://github.com/tower-rs/tower-http/pull/220! Would you mind editing your comments here with the cases that aren't handled yet? Should make it easier for people to pick up...

I think this is a great idea! Especially > Additionally, removing clone_body from Policy lets us remove the B parameter, which in turn removes the B parameter of PolicyExt methods...

@Nehliin @MarcusGrass and I (all work at embark) and have talked about this a bit. We think given the number of unanswered questions here not gonna include this in tower-http...

Returning `Result` makes most sense when you expect users to handle the errors somehow. `ensure_usable_cors_rules` checks for invalid configurations which I'm not sure how you'd handle. Maybe you can elaborate...