David Pedersen

Results 282 comments of David Pedersen

As far as I understand recursion is mainly dangerous because you risk overflowing the stack. However I think thats unlikely when diffing JSON, unless your JSON has huge levels of...

Hm I wouldn't expect recursion to impact memory usage that much. Have you tried it with just https://github.com/davidpdrsn/assert-json-diff/pull/30?

> No I have not. This would take some time. Do you need that? Yes. I don't think we refactor the code without a good reason as the change might...

Alright. Thanks for testing it! I'll actually review the code then :)

I wont say no to that. Go for it! 😅

This is something I agree would be really great to have. I have thought about it before but there is one issue I don't know how to resolve: You probably...

I don't have time to work in this at the moment but PRs are much appreciated!

Yes I think that makes sense and would be fairly straight forward to implement, its essentially how it works today except that arrays care about ordering. The hard part, like...

I think the current setup works well for deeply nested objects where you only care parts of it changing. But you're right, for arrays that might be a little confusing....