David Pedersen

Yeah thats pretty cool. Takes most of the boilerplate out of it. > Imho we could close this issue for now, given how ergonomic/powerful combining `WithRejection` + `thiserror` is. I...

@Altair-Bueno however I think we can probably extend https://github.com/tokio-rs/axum/blob/main/examples/customize-extractor-error/src/main.rs to show the three solutions: - Manually making a new extractor, i.e. what the example currently shows - Using `#[derive(FromRequest)]` like...

> You mean one crate per solution, right? We are gonna need some good self-explanatory names I don't think we need three separate crates. We can just do three modules...

I don't think we should change other examples.

With https://github.com/tokio-rs/axum/pull/1276 merged (thanks @Altair-Bueno) I think we can remove this from the 0.6 milestone.

@tomhoule that would be great 😊

@dotansimha why did you post this in 3 different places? 😅

Totally. I haven’t found a one best way to build visitors yet, but the PR that I’ve submitted is inspired by the syn crate and what I’ve found myself to...

@tailhook I have a similar visitor trait in juniper-from-schema. Here are some example of how I'm using it - Walking the AST once to gather data needed to answer questions...

I see your point but I'm not sure parsing queries will be a significant part of the time spent handling a request. But I still agree that we should be...