David Brochart

Results 783 comments of David Brochart

Good point, could you write a test that reveals this behavior?

> Since `jupyter_collaboration` isn't a document peer itself, it doesn't need to use the awareness protocol layer, we just need to broadcast awareness messages to all peers when we receive...

Tests fail because https://github.com/jupyterlab/jupyterlab/pull/15982 has not been released yet.

So https://github.com/jupyterlab/jupyterlab/pull/15982 was released in JupyterLab v4.2.0a1, but tests are still failing because JupyterLab still requires `@jupyter/ydoc >=1.1.1,

> Reduce the growth in YStore size on OOB changes > > * For example, for "small" changes, it is preferable to compute a diff and only apply that diff...

> 1. Use other file metadata from `os.stat()` to detect OOB changes more accurately. Changes in file size should be the deciding factor in whether a file was changed, not...

Thanks Zach, it's probably because of the `RTC:` prefix of the custom [YDrive](https://github.com/jupyterlab/jupyter-collaboration/blob/b3e189e199996d0b8b5214689230b6ab198c8d74/packages/docprovider/src/ydrive.ts#L29). This has been a major source of issues, as a lot of JupyterLab extensions don't handle Jupyter...

Your suggestion means that we would sometimes save, knowing that we might save again 1 second later (by default), which looks like it's not needed. You might say that if...

> 1. notebooks in subfolders spin empty without loading (on the luncher I have `RPC: [subfolder]`) You can try deleting the `.jupyter_ystore.db` file, but it's not a good sign. >...

> A more theoretical question: what is the difference between the collaboration architecture described [here](https://jupyterhub.readthedocs.io/en/stable/tutorial/collaboration-users.html) and those described [here](https://jupyterlab-realtime-collaboration.readthedocs.io/en/latest/index.html) ? The former uses the latter, giving users permissions to e.g....