David Brochart

Results 783 comments of David Brochart

It should be fixed in jupyter-collaboration v2.1.3.

> 1) whether `jupyter_server_ydoc` is still officially supported [jupyter_server_ydoc](https://github.com/jupyter-server/jupyter_server_ydoc) redirects to [jupyter-collaboration](https://github.com/jupyterlab/jupyter-collaboration). The repo was renamed and includes the TypeScript JupyterLab frontend code. Since there is no separate GitHub repo...

I didn't follow the changes that were made after the move of `jupyter_server_ydoc` to `jupyter-collaboration`. I'll let @hbcarlos and @fcollonval answer your questions.

I think the `2.x` was based on https://github.com/y-crdt/ypy-websocket/pull/86, which I didn't approve, so I don't see myself taking the `2.x` branch further. I'd be in favor of dropping `2.x`, but...

It is mostly a swap of the underlying CRDT library (ypy -> pycrdt). There were also some improvements, new tests and bug fixes by Carlos (see the [changelog](https://github.com/jupyterlab/jupyter-collaboration/blob/main/CHANGELOG.md#200)). There are...

One idea: [BaseException](https://docs.python.org/3/library/exceptions.html#BaseException) catches all built-in exceptions, while [Exception](https://docs.python.org/3/library/exceptions.html#Exception) catches all built-in, **non-system-exiting exceptions**. I think `KeyboardInterrupt` is a system-exiting exception. Maybe we catch `BaseException` instead of `Exception` somewhere, preventing...

What about putting the icons inside the cell but making them transparent, so that they appear "behind" the code?

Maybe I'm not getting the issue, but isn't it the normal behavior that another user cannot move my cursor? Even if they create a new cell and move their cursor...

As I mentioned in [this comment](https://github.com/jupyter-server/jupyter_server_ydoc/issues/49#issuecomment-1308440954), you can also use another backend for storing Y updates, for instance a [file](https://github.com/y-crdt/ypy-websocket/blob/9fb2fad3a20d8df833f8ea462d2522847d435ecf/ypy_websocket/ystore.py#L44) or a [temporary file](https://github.com/y-crdt/ypy-websocket/blob/9fb2fad3a20d8df833f8ea462d2522847d435ecf/ypy_websocket/ystore.py#L82), to check that the issue is...