jupyter-collaboration icon indicating copy to clipboard operation
jupyter-collaboration copied to clipboard

Published 20 hours ago • verified publisher icon jupyterlab

Opening from "running" panel does not use collaborative mode

Open Zsailer opened this issue 1 year ago • 3 comments

Description

If you click on the document in the "Running" panel, you will open a non-collaborative Notebook view.

Reproduce

  1. Open a notebook from the file-browser (or start a new notebook)
  2. Go to the "Running" left panel.
  3. Click on that same notebook from this panel.
  4. You will get a second view of the Notebook that is not in collaborative mode.

Expected behavior

Opening a document from the "Running" panel should also open in collaborative model.

Zsailer avatar Feb 28 '24 23:02 Zsailer

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

welcome[bot] avatar Feb 28 '24 23:02 welcome[bot]

Thanks Zach, it's probably because of the RTC: prefix of the custom YDrive. This has been a major source of issues, as a lot of JupyterLab extensions don't handle Jupyter drives, and even in JupyterLab core this is not a well supported feature. In the long run, I think it will require making the JupyterLab default drive a proper drive. But we can fix this issue with the running panel before that.

davidbrochart avatar Feb 29 '24 07:02 davidbrochart

Thanks @davidbrochart. That's right. We noticed the prefix isn't used when opening from the running panel.

Do we fix this in JupyterLab core now, in the running-extension? Or is this a Jupyter-collaboration plugin that replaces the necessary parts of the running-extension when RTC is enabled?

Zsailer avatar Feb 29 '24 20:02 Zsailer

The next version of jupyter-collaboration will no longer include the RTC: prefix, to test it today, see: https://github.com/jupyterlab/jupyter-collaboration/issues/202#issuecomment-2576097564.

I tested that this is no longer an issue in 4.0.0a0 of jupyter-collaboration - closing.

krassowski avatar Jan 08 '25 13:01 krassowski