David Brochart

Results 463 comments of David Brochart

I get this error: ``` File "/home/david/github/davidbrochart/jupyverse/plugins/auth/fps_auth/backends.py", line 164, in current_user await cookie_authentication.login(get_jwt_strategy(), active_user, response) TypeError: AuthenticationBackend.login() takes 3 positional arguments but 4 were given ``` If I change to:...

Yes, depending on the authentication mode, a cookie is set. For instance, no cookie is set if the mode is `noauth`. In this case, we always get an active user.

Not sure to understand, but I can help with testing in jupyverse.

Thanks for the explanation. > Would it be possible for the Jupyter server to first reach a login endpoint that would check for the right user configuration, set the cookie,...

I've been thinking about it and the thing is that in Jupyter we can log in at any endpoint if e.g. we provide a token in the URL. In our...

Thanks so much François, envoy your holiday!

Currently, when not in collaborative mode (i.e. only one user can work on a document), there is: - `noauth`: no authentication, all the endpoints are unprotected. - `token`: token authentication,...

The goal is to provide real user authentication and authorization, and we made some progress in that direction at some point, where we could authenticate with a GitHub account. I'm...

At the same time, I don't think his argument: > I understand this will make your code slightly less elegant in some cases, but I think in the end it...

Good point, although with nest-asyncio `asyncio.run(coro)` could almost be replaced with `await coro`, with the particularity that `await` can now be used even if the function is not `async`. It's...