David Brochart

Results 783 comments of David Brochart

This shows that observing notebook changes works as expected: ```py from jupyter_ydoc import YNotebook ynb = YNotebook() def callback(target, events): print(f"{target=}") for event in events: print(f"{str(event)=}") ynb.observe(callback) ynb.set( { "cells":...

RTC can be disabled with `jupyter lab --YDocExtension.disable_rtc=True`.

`jupyter lab --YDocExtension.disable_rtc=True` disables real-time collaboration, but the drive is still a "collaborative drive", meaning that it has the `RTC:` prefix. These two PRs will allow to get rid of...

> When `jupyter-collaboration` is installed the value for the `format` argument passed to the CM is `"json"` Could you link to the relevant code?

I just tried using Jupytext with RTC, and I get this error: ``` self._contents_manager.get( ~~~~~~~~~~~~~~~~~~~~~~~~~~^ self.path, ^^^^^^^^^^ content=False, ^^^^^^^^^^^^^^ require_hash=True, ^^^^^^^^^^^^^^^^^^ ) ^ TypeError: build_jupytext_contents_manager_class..JupytextContentsManager.get() got an unexpected keyword argument...

I just tested your branch and it seems to work fine, but I admit I don't know how Jupytext works exactly, so I cannot say it's the right way to...

> Or, are we all good because the RTC file loader can call the jupytext server-side `ContentsManager.get` to get the transformed notebook? Yes, from what I can see `jupyter-collaboration` uses...

See #257 for what it could look like.

This should only happen when two views of the same file are opened simultaneously (even for only one user), for instance a notebook file opened with the notebook editor and...

> Given that the end-user cannot do much about it (except pressing "Ok") The user is advised to close one view, so they can do that. > I would vote...