David Walsh
David Walsh
I can no longer reproduce any of these issues after this PR.https://github.com/MetaMask/metamask-extension/pull/25641
Closing with Tanya's recommendation.
Closing as test was used in https://github.com/MetaMask/metamask-extension/pull/25646
I noticed that this test was still taking a long time on Chrome so I did some more manual testing and it appears as though (assuming you kill local ganache):...
Superceded by https://github.com/MetaMask/metamask-extension/pull/25593
Seeing this with a `yarn start` locally: ``` RPC (npm:@metamask/message-signing-snap): Object -> Object TypeError: Cannot read properties of undefined (reading '0x1') '\n at AssetListControlBar (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-4.js:1765:3)\n at AssetList (chrome-extension://oehplhbehlbgjdapfkoemdgjlgbjpkkg/ui-4.js:1928:3)\n at div\n...
Shift to Confirmations as this is a gas estimation issue. Let me know if we can support!
Do you still have this issue after running `yarn setup`?
Do you see any errors in the JavaScript console?
Left a few comments; in the future, we really need to isolate our feature PRs to the issue they represent, otherwise we risk large, hard to review PRs that take...