David Walsh
David Walsh
Before merging this, I think it's a good time to introduce tests with the different values that require this change to be made.
@vesta0 @liuche How much do we want to push on this GV bug? We're relying on them to help us complete this bug.
@boek You may be interested in pushing this forward.
I inadvertantly triggered this same error with a very basic PR: https://github.com/darkwing/YouShouldUseTest/pull/7/files In that example, a syntax error is presented (`@include` instead of `@import`);
Good question @mrmakeit . I was thinking the same -- I don't think there's much we can do outside of letting the user know their stylus cannot be parsed. I...
I get the feeling that any type of `@import` is going to be a problem where we may eventually need to actually clone the repo and evaluate its entire stylus...
Do you know if this is a recent regression? I'm not seeing this in production. Flagging @NidhiKJha for review.
Started an E2E but will need to be a follow up PR -- getting it working properly is difficult at the moment because we don't have a way to open...
> For the already connected accounts, if I switch the account. I see the toast. But if I disconnect all my accounts and go to the dapp. It's not able...
Idea for e2e: add `window.stateHooks.setActiveTabOrigin` in `ui/index.js` so that we can test this