David Walsh

Results 82 comments of David Walsh

@jonybur Let's remove the test from this PR and complete as a followup -- we shouldn't block Amon Hen on a weird test issue.

Kicked CI because test failures look intermittent. This looks awesome!

Almost there! Looking really good so far!

@jonybur I can confirm I *no longer* see the strange behavior of the toast not going away. 👍

This was reverted because we took away the network picker from the send flow and this case shouldn't be allowed to happen, just as it isn't now.

Seeing this in `ui/pages/connected-accounts/connected-accounts.container.js`: ``` connectAccount: (address) => dispatchProps.addPermittedAccount(activeTabOrigin, address), ``` I'm thinking `addPermittedAccount` could be the way to go!

Also, adding a quick test in `ui/components/multichain/account-list-item-menu/account-list-item-menu.test.js` to ensure the correct action and account are used would be great!

Would doing the following allow for testing? ``` {process.env.MULTICHAIN || process.env.IN_TEST ? ( ```

Full stack trace: ``` failed to load decimals for token at 0xD648922586e98bEBF1D8F5833fb6cbe3fcF36Fcc useTokenTraker.js:71 overrideMethod | @ | backend.js:2045 -- | -- | --   | _callee5$ | @ | token.js:216   |...

Important to note that this error _does not_ break send functionality, simply throws this warning.