David Walsh

Results 82 comments of David Walsh

@Gudahtt pointed out that we have a library, `ethereum-ens-network-map`, to help determine ENS support: ``` /* from: ui/ducks/domains.js */ // import import ensNetworkMap from 'ethereum-ens-network-map'; // usage const chainIdInt =...

This PR could likely use security review and advisement

![ron-swanson-parks-and-rec](https://github.com/MetaMask/metamask-extension/assets/46655/304c121d-1561-4f35-807b-82f4c87a546d)

First of all, I cannot tell you how awesome this is. Soooooo good! A few suggestions: ## Title I think we should add a title here. Maybe "All Tokens" next...

Blocked on: https://consensyssoftware.atlassian.net/browse/MMASSETS-131

Presently blocked by: https://github.com/MetaMask/metamask-extension/pull/22551

Great idea @openjck . We may want to investigate a way to request/purchase increased rate limits as something like this would definitely, definitely limit scale. We may need multiple accounts...

Weird for `Import Account using private key of an already active account should result in an error` to fail, as I just tested it manually and I do see the...

This PR needs https://github.com/MetaMask/KeyringController/pull/161 to be merged and a new version cut.