metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

feat: Add metametrics event to switch modal confirmation

Open jonybur opened this issue 10 months ago • 3 comments

Description

Adds a tracking event to Network Switcher component

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2420

Manual testing steps

  1. Go to Uniswap, connect with Metamask
  2. Go to PancakeSwap, connect with Metamask
  3. Use PancakeSwap to change the network
  4. When clicking on "Switch network", the metametrics event should be triggered

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've completed the PR template to the best of my ability
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

jonybur avatar Apr 29 '24 14:04 jonybur

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Apr 29 '24 14:04 github-actions[bot]

seems like a lot of the checks, mostly related to e2e, are not passing, is it related to this PR?

EtherWizard33 avatar May 06 '24 20:05 EtherWizard33

@jonybur Let's remove the test from this PR and complete as a followup -- we shouldn't block Amon Hen on a weird test issue.

darkwing avatar May 07 '24 19:05 darkwing

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 67.35%. Comparing base (e775193) to head (fce55be). Report is 14 commits behind head on develop.

Files Patch % Lines
...i/pages/confirmations/confirmation/confirmation.js 0.00% 4 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24283      +/-   ##
===========================================
- Coverage    67.36%   67.35%   -0.01%     
===========================================
  Files         1282     1282              
  Lines        50011    50015       +4     
  Branches     12983    12986       +3     
===========================================
  Hits         33685    33685              
- Misses       16326    16330       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 08 '24 15:05 codecov[bot]

Builds ready [fce55be]
Page Load Metrics (831 ± 567 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint61190923215
domContentLoaded10381473
load5029538311180567
domInteractive10381473
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 658 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 08 '24 15:05 metamaskbot

Missing release label release-11.17.0 on PR. Adding release label release-11.17.0 on PR and removing other release labels(release-11.18.0), as PR was added to branch 11.17.0 when release was cut.

metamaskbot avatar May 23 '24 23:05 metamaskbot