metamask-extension
metamask-extension copied to clipboard
feat: Add metametrics event to switch modal confirmation
Description
Adds a tracking event to Network Switcher component
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2420
Manual testing steps
- Go to Uniswap, connect with Metamask
- Go to PancakeSwap, connect with Metamask
- Use PancakeSwap to change the network
- When clicking on "Switch network", the metametrics event should be triggered
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [ ] I’ve followed MetaMask Coding Standards.
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
seems like a lot of the checks, mostly related to e2e, are not passing, is it related to this PR?
@jonybur Let's remove the test from this PR and complete as a followup -- we shouldn't block Amon Hen on a weird test issue.
Codecov Report
Attention: Patch coverage is 0%
with 4 lines
in your changes are missing coverage. Please review.
Project coverage is 67.35%. Comparing base (
e775193
) to head (fce55be
). Report is 14 commits behind head on develop.
Files | Patch % | Lines |
---|---|---|
...i/pages/confirmations/confirmation/confirmation.js | 0.00% | 4 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## develop #24283 +/- ##
===========================================
- Coverage 67.36% 67.35% -0.01%
===========================================
Files 1282 1282
Lines 50011 50015 +4
Branches 12983 12986 +3
===========================================
Hits 33685 33685
- Misses 16326 16330 +4
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Builds ready [fce55be]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (831 ± 567 ms)
Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
---|---|---|---|---|---|---|---|
Chrome | Home | firstPaint | 61 | 190 | 92 | 32 | 15 |
domContentLoaded | 10 | 38 | 14 | 7 | 3 | ||
load | 50 | 2953 | 831 | 1180 | 567 | ||
domInteractive | 10 | 38 | 14 | 7 | 3 |
Bundle size diffs
- background: 0 Bytes (0.00%)
- ui: 658 Bytes (0.01%)
- common: 0 Bytes (0.00%)
Missing release label release-11.17.0 on PR. Adding release label release-11.17.0 on PR and removing other release labels(release-11.18.0), as PR was added to branch 11.17.0 when release was cut.