fix: asset list showing fiat symbol instead of native

[bergeron]

Description

Problem: With Primary currency = Fiat, the home page showed Ethereum's symbol as USD instead of ETH.

Related issues

Manual testing steps

• Set primary currency in settings to Fiat
• Ethereum's symbol should be "ETH" on the home page

Screenshots/Recordings

Before

https://github.com/MetaMask/metamask-extension/assets/3500406/1238aa4c-9a01-464d-8a87-1496744175d2

After

https://github.com/MetaMask/metamask-extension/assets/3500406/7495e8c6-51a4-4bbd-9f96-5d12a8508a6c

Pre-merge author checklist

• [ ] I’ve followed MetaMask Coding Standards.
• [ ] I've clearly explained what problem this PR is solving and how it is solved.
• [ ] I've linked related issues
• [ ] I've included manual testing steps
• [ ] I've included screenshots/recordings if applicable
• [ ] I’ve included tests if applicable
• [ ] I’ve documented my code using JSDoc format if applicable
• [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• [ ] I’ve properly set the pull request status:
  • [ ] In case it's not yet "ready for review", I've set it to "draft".
  • [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions[bot]]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[darkwing]

Do you know if this is a recent regression? I'm not seeing this in production. Flagging @NidhiKJha for review.

[bergeron]

Do you know if this is a recent regression? I'm not seeing this in production. Flagging @NidhiKJha for review.

Correct. This occurs on develop, not the current prod release. This appears to be the change that exposed the issue: https://github.com/MetaMask/metamask-extension/pull/22601. But I think bug was there before, we just weren't showing symbol until that PR.

develop w/bug:

prod:

[gauthierpetetin]

Hello @bergeron , we just had a look at this during bug triage session and noticed there's still ETH displayed on the "After" video posted in this PR's description.