Darius Clark comments

Results 202 comments of


                                            Darius Clark

`libp2p_stream` stream deadlocks if using yamux 0.13

> Hi [@indietyp](https://github.com/indietyp) have you been able to reproduce this lately, and can you share the code you make use of `libp2p-stream`? > > > It seems that the yamux...

`libp2p_stream` stream deadlocks if using yamux 0.13

I did test by increasing the amount of data going over quic and it does seem to have an similar effect to what goes on under yamux, so you are...

Add libp2p-connection-tracker for simplified peer connection state management

Thanks for the PR! Im not 100% sure about this since as @elenaf9 mentioned that most behaviours would want to track the connection state of each peer for explicit reasons....

Panic in `libp2p-websocket` at 'SinkImpl::poll_ready called after error.'

could you provide your configuration on how youre using yamux or are you using the default configuration? Any logs you could provide up to the panic?

webrtc Flag not being transferred

I am not completely well versed in the webrtc implementation in libp2p (and only know a bit about the specs) but based on the information provided, it sounds like option...

`PeerId::from_bytes` should be const

For the time being wouldnt it be possible for you to use `LazyLock` for the construction of the `PeerId` that you wish to use in your test?

fix(kad): enforce a timeout for inbound substreams

> Unfortunately not (or not without a larger refactor). `FuturesTupleSet` holds `Future`s, but inbound substreams are implemented as `Stream`s in `kad`: Could we not use `StreamSet` from `futures-bounded`? EDIT: Or...

Ability to query Kademlia peers via behaviour API

Hey! It sounds like you might be looking for `Behaviour::get_closest_peers`, no? https://github.com/libp2p/rust-libp2p/blob/93ad28c4cce236b1657241ba623ea30077565afd/protocols/kad/src/behaviour.rs#L730-L739

chore: use if-watch-plus instead of if-watch

Thanks for the PR! Can you update the workspace `Cargo.toml` as well? :)

chore: use if-watch-plus instead of if-watch

Since if-watch was moved to llibp2p org, this issue could be closed now no? CC @jxs