chore: use if-watch-plus instead of if-watch
Description
Libp2p relies on a package called [email protected] in 4 different places:
transport/tcptransport/quictransport/webrtcprotocol/mdns
This unmaintained library uses a deprecate iOS interface through one of its own dependencies `[email protected]:
- https://discuss.libp2p.io/t/rust-libp2p-link-error-on-ios-undefined-symbols-kscnetworkinterfacetypeirda/2208
- https://github.com/libp2p/rust-libp2p/issues/5140
Seeing that our bindings use this deprecated interface, iOS apps will fail to build for everyone using rust-libp2p.
Notes & open questions
- This PR uses a forked version of
if-watchthat only updates thesystem-configurationsdependency to the latest version that addresses the deprecated interface - This PR does not cover tests that should fall under
system-configurations
Change checklist
- [x] I have performed a self-review of my own code
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] A changelog entry has been made in the appropriate crates
Thanks for the PR! Can you update the workspace Cargo.toml as well? :)
Thanks for the PR! Can you update the workspace
Cargo.tomlas well? :)
Update me if there is anything else I forgot to do :)
Hi, in the rust-libp2p community call I remarked that it was strange that if-watch was unmaintained, but I have since found https://github.com/mxinden/if-watch/pull/37#issuecomment-2200783907, I have also acted upon it and wrote https://github.com/mxinden/if-watch/pull/37#issuecomment-2408162877. So I suggest we wait to move the repo and I can then accept a PR there and release a new version.
This pull request has merge conflicts. Could you please resolve them @RawinSader? 🙏
Since if-watch was moved to llibp2p org, this issue could be closed now no?
CC @jxs
If we do close this would you want me to submit another PR to the new repo?
If we do close this would you want me to submit another PR to the new repo?
Yes please :)
Closing due to if-watch repo ownership changed to libp2p org.