rust-libp2p icon indicating copy to clipboard operation
rust-libp2p copied to clipboard

chore: use if-watch-plus instead of if-watch

Open RawinSader opened this issue 1 year ago • 4 comments

Description

Libp2p relies on a package called [email protected] in 4 different places:

  • transport/tcp
  • transport/quic
  • transport/webrtc
  • protocol/mdns

This unmaintained library uses a deprecate iOS interface through one of its own dependencies `[email protected]:

  • https://discuss.libp2p.io/t/rust-libp2p-link-error-on-ios-undefined-symbols-kscnetworkinterfacetypeirda/2208
  • https://github.com/libp2p/rust-libp2p/issues/5140

Seeing that our bindings use this deprecated interface, iOS apps will fail to build for everyone using rust-libp2p.

Notes & open questions

  • This PR uses a forked version of if-watch that only updates the system-configurations dependency to the latest version that addresses the deprecated interface
  • This PR does not cover tests that should fall under system-configurations

Change checklist

  • [x] I have performed a self-review of my own code
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] A changelog entry has been made in the appropriate crates

RawinSader avatar Oct 05 '24 23:10 RawinSader

Thanks for the PR! Can you update the workspace Cargo.toml as well? :)

dariusc93 avatar Oct 08 '24 16:10 dariusc93

Thanks for the PR! Can you update the workspace Cargo.toml as well? :)

Update me if there is anything else I forgot to do :)

RawinSader avatar Oct 09 '24 00:10 RawinSader

Hi, in the rust-libp2p community call I remarked that it was strange that if-watch was unmaintained, but I have since found https://github.com/mxinden/if-watch/pull/37#issuecomment-2200783907, I have also acted upon it and wrote https://github.com/mxinden/if-watch/pull/37#issuecomment-2408162877. So I suggest we wait to move the repo and I can then accept a PR there and release a new version.

jxs avatar Oct 11 '24 21:10 jxs

This pull request has merge conflicts. Could you please resolve them @RawinSader? 🙏

mergify[bot] avatar Oct 15 '24 17:10 mergify[bot]

Since if-watch was moved to llibp2p org, this issue could be closed now no?

CC @jxs

dariusc93 avatar Nov 08 '24 11:11 dariusc93

If we do close this would you want me to submit another PR to the new repo?

RawinSader avatar Nov 10 '24 20:11 RawinSader

If we do close this would you want me to submit another PR to the new repo?

Yes please :)

dariusc93 avatar Nov 10 '24 20:11 dariusc93

Closing due to if-watch repo ownership changed to libp2p org.

dariusc93 avatar Nov 11 '24 03:11 dariusc93