Darius Clark

Results 202 comments of Darius Clark

I do like the idea of having this configurable as 20 may not always be suited for every use-case (though I do understand its reasoning for being that by default)....

Theres also `ArrayVec` which takes a const (which uses `K_VALUE` to determine its max cap). Havent looked at that crate myself but my guess is we could probably switch to...

> The [specs](https://github.com/libp2p/specs/blob/master/identify/README.md) doesn't seem to have any information about what to do when there is a pubkey mismatch. An event of it can be emitted though. Thats a good...

For now, at least until it is determined in the specs, I think we should propagate the error to the behaviour and emit it to swarm with the connection id...

> that on the other hand makes it so that by default nothing happens, as it is delegated to the user. Without thinking much I'd rather close the connection, is...

I do agree with the idea of replacing `async-std` with `tokio` as well. Maybe start with the tests and following #4449 we can move on to preferring `tokio` in other...

> If it doesn't add too much CI and maintenance overhead, IMO it is nice to have. I guess many developers are building from macOS. I agree if it doesnt...

Thanks for the report. Not sure why it would be giving that error or why its finding one gateway and not the other, but i do know some firmwares dont...

> @mxinden Still looking for help on this one? I can take it Hey! You're welcome to take a shot at it as any PRs are welcomed :)

I have attempted this myself a few months ago but couldnt really settle on how I would want but do think we could go with 2, which would keep inline...