Darius Clark

Results 202 comments of Darius Clark

Hey! Interesting find. I would have always assumed that using `dnsaddr` in this manner for websocket is fine but it does make sense that it would be meant to query...

Thank you for the report. It looks like it happens when receiving an event from the behaviour. https://github.com/libp2p/rust-libp2p/blob/ad7ad5b3fc5b4bc9a431ece90e9a5ce8c33ca0e2/swarm/src/handler/either.rs#L102-L108 Could you provide any code to reproduce it and any possible logs?

> Ready for review. CI failure does not seem related to this PR. Youre right. That is unrelated and would be handled in a different PR in the future.

> IMHO we'd just remove async-std code and stick to tokio, if anyone needs smol for a particular transport they can have and maintain a fork on their own repos,...

> I would like to keep the abstraction layer to make it easier for users who wants to make an adapter, but not very strongly. Rust has zero-cost abstractions right?...

> Does this also mean `tokio` feature can be made enabled by default with `default-features = false` required to opt-out? I believe that would be a great developer experience upgrade....

> Can we not soft deprecate and just hard deprecate? CC @elenaf9 @dariusc93 Would there be any reason to suddenly do a hard deprecation vs soft? Imo, I think we...

Hey! Thank for the question. Currently, rust-ipfs would not be doing anything additional internally such as a RPC API. This would likely need to be done externally. I may consider...

A simple fix. I may do it quickly if nobody else has already done it

Is there any resolution for this issue?