Dario Russi

Results 46 comments of Dario Russi

just a quick comment as I am reviewing this, and it will be slow for me as it touches a lot of core stuff I have not seen before. Though...

@lightmark not sure if this is a side effect of this fix or if the behavior was always there but `cargo test test_txn_emmitter -- --ignored` never terminates, whereas if I...

this has been replaced by #8645 closing soon

I see what we are doing... this is so much more clear that the simple contrived example you pointed me to :D thanks

> I'm thinking at least we should write some stand alone unit tests for the stack itself. Past that, I'm a bit less worried about tests for the specific passes....

also to better contextualize what I said in the main comment, this PR adds the normalization just before returning transaction effects in `execute_transaction_to_effects`. And I am not sure if there...

@sblackshear @lxfind talking to Move and wallet/sdk people it seems this feature can get problematic. Particularly with programmable transactions, but even with regular ones, a user can run out of...

so this is likely not happening for now if ever. I'll leave it open for a bit to let people comment if they have any, then I'll close it

I am going to close this soon, please comment if you think otherwise