aptos-core icon indicating copy to clipboard operation
aptos-core copied to clipboard

[txn-emitter] fix nft_mint_and_transfer

Open lightmark opened this issue 2 years ago • 2 comments

Description

now cargo test test_txn_emmitter -- --nocapture --ignored works. but it takes "1678.65s" to run because for each of our 240 workers, the initial setup takes several seconds to fund the nft_faucet account.

Test Plan

cargo test test_txn_emmitter -- --nocapture --ignored


This change is Reviewable

lightmark avatar Oct 03 '22 22:10 lightmark

@lightmark not sure if this is a side effect of this fix or if the behavior was always there but cargo test test_txn_emmitter -- --ignored never terminates, whereas if I comment out this line (TransactionType::NftMintAndTransfer, 10), in txn_emitter.rs the test terminates after a number of seconds. Not sure what the expectation is and it's not a big deal for me, but I figured I'd mention

dariorussi avatar Oct 04 '22 16:10 dariorussi

@dariorussi see the description on the PR. It takes almost half an hour to finish because the setup take several seconds for each worker and we have 240 workers. Donno whether it is an issue for txn-emitter... @igor-aptos I guess I can just do it for my local forge test if it's not okay.

lightmark avatar Oct 04 '22 17:10 lightmark