sui icon indicating copy to clipboard operation
sui copied to clipboard

[sui-execution] Move `sui` execution crates into their own directory

Open amnn opened this issue 1 year ago • 3 comments

Description

Create the sub-directory containing the "latest" version of sui- crates in the execution layer. API to access multiple versions of an execution crate to follow. This commit just moves code to its new home, to minimise the chance for a merge conflict.

Test Plan

$ cargo simtest
$ env SUI_SKIP_SIMTESTS=1 cargo nextest run

amnn avatar Apr 21 '23 16:04 amnn

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) May 11, 2023 9:12pm
explorer-storybook ⬜️ Ignored (Inspect) May 11, 2023 9:12pm
sui-wallet-kit ⬜️ Ignored (Inspect) May 11, 2023 9:12pm
wallet-adapter ⬜️ Ignored (Inspect) May 11, 2023 9:12pm

vercel[bot] avatar Apr 21 '23 16:04 vercel[bot]

Addressing some potential review comments up-front:

  • Originally, sui-execution was within crates but this triggered a linter warning that crates needs to have a flat directory structure.
  • It's useful to have all the execution crates from the same version in the same directory (e.g. sui-execution/latest) rather than flatten them out, because then they can refer to each other by relative paths, and when we cut a new version, we don't need to touch this part.

amnn avatar Apr 21 '23 16:04 amnn

I see what we are doing... this is so much more clear that the simple contrived example you pointed me to :D thanks

dariorussi avatar Apr 21 '23 23:04 dariorussi

@dariorussi, versioning for the move crates and the sui-execution versioned crate that the TODOs refer to are to come in a follow-up PR, because they are also pretty big changes on their own. The TODOs are meant to be here as a reminder to me for where I need to change references to the "latest" version of the execution crate to point to the crate that dispatches by version.

amnn avatar May 11 '23 22:05 amnn