sui icon indicating copy to clipboard operation
sui copied to clipboard

[move] Remove signer from the source language

Open tnowacki opened this issue 1 year ago • 5 comments

Description

  • Removed signer from the source language
  • Fixed various tests and tools

Test Plan

  • Updated tests

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • [ ] protocol change
  • [ ] user-visible impact
  • [ ] breaking change for a client SDKs
  • [ ] breaking change for FNs (FN binary must upgrade)
  • [ ] breaking change for validators or node operators (must upgrade binaries)
  • [ ] breaking change for on-chain data layout
  • [ ] necessitate either a data wipe or data migration

Release notes

tnowacki avatar Nov 22 '23 18:11 tnowacki

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 6:57pm
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 6:57pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2023 6:57pm
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2023 6:57pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2023 6:57pm

vercel[bot] avatar Nov 22 '23 18:11 vercel[bot]

We might break someones code out there, but since there is no way of generating signers in Sui, this is probably unlikely?

tnowacki avatar Nov 22 '23 18:11 tnowacki

Blocked on #14999 landing into testnet

tnowacki avatar Nov 22 '23 22:11 tnowacki

this is still blocked right?

dariorussi avatar Dec 08 '23 16:12 dariorussi

this is still blocked right?

It will be blocked until that code hits testnet

tnowacki avatar Dec 08 '23 21:12 tnowacki

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Feb 07 '24 01:02 github-actions[bot]