Dan Schultzer

Results 190 comments of Dan Schultzer

Also one thing on all my PRs, I can update the changelog if it's preferred to do in the PR's. I'm not sure how the releases are managed.

I see, but then do we need to fixate the semantic conventions version to `1.27`? Because it's at `1.29` now with more breaking changes, so whenever the semconv library gets...

@bryannaegele 1.18 now causes deprecation warnings to show up so the compile with warnings as errors fails in CI. We could close this PR and move on to #436 where...

I pushed a commit to hardcode the keys to have this go green on CI, but you can work on this fork as you see fit @bryannaegele.

Right, this is a breaking change, I've updated the issue to mention this thanks! This is LiveView specific though so there is no direct spec we can use for this,...

And to expand on why adding the route to the span name; I'm adding the route template to the span name as it works better than just the live module....

> Our instrumentation libraries cannot include dependencies on the library being instrumented. There are a few reasons for this but as you come up with ideas or proposals just know...

I don’t think there’s anything you can do @epinault. I’ve been waiting since December for my PRs to be reviewed, but this repo is in low maintenance mode with only...

Why is it necessary with this conditional?

What OIDC provider are you using? AFAIK `none` is valid, and providers I've used returns that value in the `token_endpoint_auth_methods_supported` list. It's not clear from the [core RFC](https://openid.net/specs/openid-connect-core-1_0.html) whether the...