Dan Schultzer

Results 190 comments of Dan Schultzer

Yeah, I see that. Did you find a solution for this? I would like to explore how this can be optimized, but realistically I likely won't have much time to...

Turning this to draft until I can figure out how to make this not depend on `:phoenix_live_view` as per https://github.com/open-telemetry/opentelemetry-erlang-contrib/pull/433#issuecomment-2547269703: > Our instrumentation libraries cannot include dependencies on the library...

Yeah, I think it's good enough for a 1.0 release. I've this still not entirely fleshed out idea in mind that TestServer should be more generally focused than just the...

I’ve opened this PR to resolve this: https://github.com/open-telemetry/opentelemetry-erlang-contrib/pull/435

I've a lot of the 1.27 spec work for Oban done in https://github.com/open-telemetry/opentelemetry-erlang-contrib/pull/436 but there's more to it, and requires deeper review. I've asked some questions there and laid out...

Ah ok. When I get a moment I'll go over #436 again to see what's missing. My goal was to only touch the attributes that were incorrect and fixing the...

You would normally want to scrub it with a processor: https://opentelemetry.io/docs/security/config-best-practices/#scrub-sensitive-data

Moving to 1.27 here (1.27 is the latest SemConv hex package): https://github.com/open-telemetry/opentelemetry-erlang-contrib/pull/430

I missed this PR, but I have been updating Oban to 1.27 conventions in #436. There's more to it as well, e.g. creation context. Also I want to track everything...

Yes, it's all in the followup PR #436, which adheres as much as possible to 1.27 specs for messaging. But it'll introduce many breaking change. This PR only focuses on...