opentelemetry-erlang-contrib icon indicating copy to clipboard operation
opentelemetry-erlang-contrib copied to clipboard

Conform attributes to v1.27 semantics for OpentelemetryOban

Open danschultzer opened this issue 10 months ago • 10 comments

Stacked on #435 which needs to get in first. Check the latest commit for the changes here.

Follows the guideslines set out in https://github.com/open-telemetry/semantic-conventions/blob/v1.27.0/docs/messaging/messaging-spans.md#destinations

This does introduce a bunch of breaking changes so let me know if backwards compability is required. I can keep the old attributes, but not sure if we should just go with major release instead since there's a lot of things that are different now? Same question as in #430

Changes

  • messaging.destination -> messaging.consumer.group.name
  • messaging.destination.kind is removed
  • Span names {destination} {operation} changed to{operation} {destination}
  • Span names {plugin} process changed to oban.plugin {plugin}
  • Span names Oban bulk insert changed to {operation} or {operation} {destination} depending whether all are the same job type

Added

  • messaging.destination.name (the worker module)
  • messaging.operation.name
  • messaging.operation.type
  • messaging.message.id

There's also more to this to get it to be compliant with 1.27 conventions. A larger one is that we probably need to deal with creation context? https://github.com/open-telemetry/semantic-conventions/blob/v1.27.0/docs/messaging/messaging-spans.md#context-propagation


Related #367

danschultzer avatar Dec 15 '24 15:12 danschultzer