Dan Schultzer

Results 190 comments of Dan Schultzer

@morgz thanks! I agree, socket/liveview integration is high priority. I've a general idea of how session renewal should work, based on how LiveView [deals with flash messages](https://github.com/phoenixframework/phoenix_live_view/blob/v0.12.1/lib/phoenix_live_view/router.ex#L174-L184). I hope the...

> As a learning dev that is a big advantage. Yup, I agree. It's the big advantage of `phx.gen.auth`, but it's a double edged sword as you also get all...

Iframes should not be permitted for OAuth 2.0 flow: https://tools.ietf.org/html/draft-ietf-oauth-v2-23#section-10.13 I believe Github sets the `x-frame-options` header to prevent clickjacking. So your only option is to either use the authorization...

I would either mock the strategy or the http adapter . Normally I mock the http adapter: ```elixir defmodule MockHTTPAdapter do @moduledoc false alias Assent.HTTPAdapter.HTTPResponse def request(:post, "http://example.com/oauth/access_token", body, _headers,...

> Would it be helpful if I opened a PR with some guide examples based on this? Yeah it would! 😄

If I understand this correctly, the only difference in with the two strategies is the client id (and no client secret for ios)? You use PowAssent in the API with...

> I'm working on adding "incremental auth" support for a Pow Assent powered web application, and figure `merge_provider_config` would also be the recommended path for achieving such a thing? Yeah...

Can you verify that the `:id` printed does match with an existing record? Does this happen every time you log in? The reload logic just pulls the primary key(s) for...

This makes a lot of sense. I’ll see if it’s possible with Pow. It ties in with the custom with flow planned with https://github.com/danschultzer/pow/issues/6

Related: https://github.com/pow-auth/pow_assent/issues/18