Dan Schultzer

Results 190 comments of Dan Schultzer

> How can I handle such cases? (I think probability of this occuring is high with discord as discord allows having same username for multiple users and differentiate with username#12123,...

The issue is here: https://github.com/pow-auth/pow_assent/blob/v0.4.7/lib/pow_assent/ecto/user_identities/context.ex#L213 When there's an error on email then it triggers the `{:error, {:invalid_user_id_field, changeset}}` error which will redirect to the add-user-id form. It can be solved...

There seems to be several things going on here. First can you try to update the `RedisCache` to the latest revision: https://hexdocs.pm/pow/1.0.25/redis_cache_store_backend.html#content That should take care of the `nil` raise...

Yeah, the `fetch_user/3` call in `Assent.Strategy.OAuth2` should have a fourth argument for headers. That would solve this issue. Please do open a PR for https://github.com/pow-auth/assent!

Thanks, it's in master branch, I'll release a new version soon. Feel free to open another PR to add Twitch support in Assent 😄

It shouldn't run twice since if one succeeds and a user gets assigned, the other will just continue without attempting any operation: https://github.com/pow-auth/pow_assent/blob/v0.4.11/lib/pow_assent/plug.ex#L122-L190 The `pow_assent_persistent_session` plug function will only be...

Thanks for the work @fastjames and @aaronsakowski! I resolved this in a different way in #100 (described why in https://github.com/danschultzer/ex_oauth2_provider/pull/98#issuecomment-1666591731).

@thiagomajesk I agree, and apologize for not having been more proactive on this. Now with Phoenix 1.7 being this liveview heavy it is more pressing than ever. I’ve been transitioning...

Sounds great @sorentwo, thanks for looking at this! I did make a quick PR in #468 to pass hackney opts which solves part of the issue. But it would be...

Actually we don't see the exceptions happening in our use case. It's weird, it seems that the conn/conn.adapter doesn't persist with the measurement, even though `send_resp` gets called so it...