Daniel Marjamäki

Results 389 comments of Daniel Marjamäki

if you change misra.py rule 10.3 so that it warns I am not against it.

I have the feeling that C89 does not have a "bool" type. And one possible way to use bools would be: ``` typedef int bool; #define true 1 #define false...

> Maybe dependent on Code Standard for C89 allow 0 and 1 and for C99 not? Sounds good to me.

Basically I agree with the idea. If `-DFOO --max-configs=2` is used then I would expect that 2 configurations that both define `FOO` is checked. You can add an example that...

I would also like to see some regression tests.

> The duplicated and differing logic in the CLI and GUI code make things a bit awkward. yes.. if we can unify logic that would make me happy.. :-)

@clock999 sorry for late response. do you want to continue working on this? I would like that we have consistent proper behavior when --max-configs is used.

> As I understand, the values of the items of the Settings should all be read only, which are only decided by the user input. this is more or less...

> We will have 4 checks. That is just our current behavior in fact. This is the expected behavior imho > So if using the options '--max-configs=3 -DAAA', we just...

> So when a project file is imported, even though there is no defines in the project file, shall we ignore all the config checks? Spontanously I feel that: *...