Daniel Marjamäki

> Are you suggesting to drop the feature as a whole? yes personally I would like to drop this feature. I believe it is deprecated since about 10-15 years.

> There are cases where PCRE Rules are still helpful, for example to enforce some very simple rules, such as forbidding special keyword usage like goto. If we could at...

> #6211 at least tries to encapsulate it so it could be replaced with something else. :+1: I don't know the exact difference of PCRE and C++ regex but I...

> PCRE is super fast and std::regex is probably the slowest implementation in history so it is basically unusable. I would understand that argument if it was executed directly on...

> Where I still use the rules, its actually for cases where I have a more complicated regex(such as that looks like a case that would benefit to be implemented...

could you lookup if there was such tests added already when this FN was fixed. which SHA fixed the FNs? (It is supposed to be fixed during last 5 months)

The test is unfortunate because it does not detect a regression. There are two possible ValueFlow solutions for this test: * either ValueFlow can determine that both i and j...

> either ValueFlow can determine that both i and j will be 0 and then when those are are multiplied there will be division by zero. Both loops are required...

Off the top of my head I believe a test suite could also for instance have similar loops with: * modulo with zero * array index underrun * shift overflow...

> Maybe we should add include detection here: > > https://github.com/danmar/cppcheck/blob/dc385f3b4a4b94507ff21f2ec428fd6cb0366ea5/tools/donate_cpu_lib.py#L680 sorry is this related to this PR?