Daniel Marjamäki
Daniel Marjamäki
> I also executed the test-my-pr.py, but sometimes it will fail for network problems, or executing timeout, etc. Once failed, it will start from the beginning when being executed again....
I would like to add documentation about checkers. I have this work in progress for "cstyleCast": https://github.com/danmar/cppcheck/pull/7539 Could you add some such page for your new checker. I think the...
This test case could be interesting also: https://github.com/danmar/cppcheck/pull/7406#issuecomment-2872593612 ``` void foo(int x, int y=0) ; void bar() { if (foo(x,y),z) {} } ``` it's not a misplaced parenthesis in this...
> Regarding the "extra argument", do you mean that the user actually don't want the argument y, foo(x) is the intent, but foo(x, y) is a carelessness? please ignore this...
I don't understand this. Do I understand it correctly that if a violation is found then the junit xml will say that it is a testcase. Imho you should look...
you did not specify which ci you use. but there are already options: * you can save the output in xml format, by using cppcheck option --xml. Some CIs understand...
@aygupt1822 can you clarify? what kind of ci pipeline do you use? what would the output look like. Does it show errors as failed test cases? So it indicates that...
Hi, sorry for the late review. I spontanously feel this might be too "stylistic" in nature. It's not to find "buggy" code, is it? What bugs could it lead to?...
The implementation: I don't have major complaints. It's pretty good. But some test cases is needed and also I think a ticket should be added in trac and the release...
> This would not help prevent bugs to the code but would help increase readability at some places. I would add the required test cases. well.. I don't know why...