deps: bump cosmos-sdk to v0.50.8

[damiannolan]

Description

closes: #6822 #6825 #6827 #6826 #6824 #6823

---

Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

• [ ] Targeted PR against the correct branch (see CONTRIBUTING.md).
• [ ] Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
• [ ] Code follows the module structure standards and Go style guide.
• [ ] Wrote unit and integration tests.
• [ ] Updated relevant documentation (docs/).
• [ ] Added relevant godoc comments.
• [ ] Provide a conventional commit message to follow the repository standards.
• [ ] Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
• [ ] Re-reviewed Files changed in the GitHub PR explorer.
• [ ] Review SonarCloud Report in the comment section below once CI passes.

[damiannolan]

There looks to be some failing unit tests here

[damiannolan]

Let's hold off on merging this until we understand why this change broke our tests:

cc. @julienrbrt @tac0turtle

I'm unsure what the implications of this change really means, so would be nice to understand it better. (edit: I see this is for supporting nested any's from the perspective of multisig keys. Seems like there is not symmetry between LegacyAminoPubKey when created with kmultisig.NewLegacyAminoPubKey() (packPubKeys) and unmarshalled LegacyAminoPubKey which use the AnyUnpacker interface.).

I could get the tests passing again with:

diff --git a/crypto/keys/multisig/multisig.go b/crypto/keys/multisig/multisig.go
index e28aa012d8..e31a48170b 100644
--- a/crypto/keys/multisig/multisig.go
+++ b/crypto/keys/multisig/multisig.go
@@ -156,6 +156,12 @@ func (m *LegacyAminoPubKey) UnpackInterfaces(unpacker types.AnyUnpacker) error {
                if err != nil {
                        return err
                }
+
+               if pk != nil {
+                       if err = any.UnmarshalAmino(pk.Bytes()); err != nil {
+                               return err
+                       }
+               }
        }
        return nil
 }
(END)

Would like to get a better understanding of any.compat, I see it gets unset here explicitly too (https://github.com/cosmos/cosmos-sdk/blob/v0.50.8/codec/types/compat.go#L98-L100)

[crodriguezvega]

I will close in the meantime the other dependabot PRs to reduce the noise...

[DimitrisJim]

do we want to keep open? would assume there would be a patch release for this at some point?

[damiannolan]

do we want to keep open? would assume there would be a patch release for this at some point?

Yeah I think we can keep it open. There is a PR open here which I just updated to here to test https://github.com/cosmos/cosmos-sdk/pull/21019

[damiannolan]

There will be a new patch release this week. I'll update this PR when it becomes available.

Converting to draft for now

[DimitrisJim]

well shit, that did not work, changelog for tx mentioned reversion https://github.com/cosmos/cosmos-sdk/commit/564cc4d370d64d1c449a170a987f450a4a91e306 which I thought was issue?

at least I addressed the conflicts, commit that Damian was using before was github.com/cosmos/cosmos-sdk v0.50.9-0.20240722112539-25d481f797ca (dropping here just in case)

[julienrbrt]

Could you try out with the latest commit from release/v0.50.x? 3f6796fba413cca7f2ea9a7e03d7965e7eda7378

[julienrbrt]

Once you confirm it works, we can release v0.50.9.

[DimitrisJim]

@julienrbrt all seems green in the run. Thanks for the fix and ping!

[sonarqubecloud[bot]]

Quality Gate passed for 'ibc-go'

Issues
24 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud