ics23 icon indicating copy to clipboard operation
ics23 copied to clipboard

feat: add api folder containing pulsar generated code.

Open DimitrisJim opened this issue 1 year ago • 2 comments

Required for https://github.com/cosmos/ibc-go/pull/5968#

Protos contain only primitive types so generation was straigh-forward. Would be a good idea to add a step to the go workflow that enters the mod and does a sanity go build ./...

DimitrisJim avatar Apr 17 '24 16:04 DimitrisJim

Thanks @DimitrisJim!

Happy to leave this open or switch to draft. Likely won't need to merge this if we don't need protov2 and can use gogoproto.

damiannolan avatar Apr 18 '24 08:04 damiannolan

moving to draft per Damian's comment!

DimitrisJim avatar Apr 18 '24 08:04 DimitrisJim

This can be closed as pulsar is no longer required. see https://github.com/cosmos/cosmos-sdk/issues/20134

damiannolan avatar Aug 26 '24 09:08 damiannolan